color change on php coding

[webtech]

i'm trying to change the color code but it doesn't work. can you pls check following code.
<?
if ($submit) {

else if($name == False)
{
$error = "You must enter all fields";

}

else if($email == False)
{
$error = "You must enter all fields";
}



else
{
$k=false;
//store
$result = mysql_query($sql_query);

while ($row = mysql_fetch_row($result))
{
if ($row[1] == $name)
{
echo "<br>This name is already EXISTS.<br><br>";

$k=True;
}
}

if (!$k)
{
$sql_query1 = "INSERT into company (Name, Email) VALUES('$name', '$email')";
$result1 = mysql_query($sql_query1);

}
echo "Thank You!";
}

}

if (!$submit || $error) {

echo $error;
?>
<form action="<?php echo $PHP_SELF ?>" method="post" name="form1">
<table width="100%" border="0" cellpadding="0" cellspacing="1" align="center" class="tborder">

<tr>
<td> Please fill in the form below.<br><br>

</td>

</tr>
<tr align="center">
<td class="alt2" width="200"><div align=right><b><font <? if ($error){echo "color=#ff0000";} ?>>*Name </font></b></div></td>
<td class="alt2"><div align=left><input type=text name=name value="<?php echo $name ?>" class=bginput size=50>
</div></td>
</tr>
<tr align="center">
<td class="alt2" width="200"><div align=right><b><font <? if ($error){echo "color=#ff0000";} ?>>*email
</font></b></div></td>
<td class="alt2"><div align=left><input type=text name=email value="<?php echo $email ?>" class=bginput size=50>
</div></td>
</tr>
<table>
</form>

[Tris]

May I just ask what does not work?

The color not change?

[webtech]

May I just ask what does not work?

The color not change?

yea the title of field(text box) color will not changed

[Lippy]

Personally I would do an iff statement. two copies of the code in that file, one has the red text the other has black text. Just easier and in my opinion.

[Tris]

I changed the code a bit

first i used empty() instead of false (Just personal preference there).

Secondly and this is where you get the error you do

if ( !$submit || $error ) {
echo $error;

and dont close it. I also changed the if($error) to if(isset($error)). Again personal preference. Also neatened it a bit also. This should work. if not please just tell me. Ill fix it.

<?php
if ( $submit ) {
    else if ( empty($name) ) {
        $error = "You must enter all fields";
    } else if ( empty($email) ) {
        $error = "You must enter all fields";
    } else {
        $k = false; 
        // store
        $result = mysql_query( $sql_query );

        while ( $row = mysql_fetch_row( $result ) ) {
            if ( $row[1] == $name ) {
                echo "<br>This name is already EXISTS.<br><br>";

                $k = true;
            } 
        } 

        if ( !$k ) {
            $sql_query1 = "INSERT into company (Name, Email) VALUES('$name', '$email')";
            $result1 = mysql_query( $sql_query1 );
        } 
        echo "Thank You!";
    } 
} 

if ( !$submit || $error ) {
    echo $error;
}
    ?>
<form action="<?php echo $PHP_SELF ?>" method="post" name="form1">
<table width="100%" border="0" cellpadding="0" cellspacing="1" align="center" class="tborder">

<tr> 
<td> Please fill in the form below.<br><br>

</td>

</tr>
<tr align="center"> 
<td class="alt2" width="200"><div align=right><b><font <?php if ( isset($error) ) {
        echo "color=#ff0000";
    } 
    ?>>*Name </font></b></div></td>
<td class="alt2"><div align=left><input type=text name=name value="<?php echo $name ?>" class=bginput size=50> 
</div></td>
</tr>
<tr align="center"> 
<td class="alt2" width="200"><div align=right><b><font <?php if ( isset($error) ) {
        echo "color=#ff0000";
    } 
    ?>>*email 
</font></b></div></td>
<td class="alt2"><div align=left><input type=text name=email value="<?php echo $email ?>" class=bginput size=50> 
</div></td>
</tr>
<table>
</form>

[Tris]

Just want to make sure?

Does it work now?

[michal]

Just want to make sure?

Does it work now?

yea its work but i didn't use "isset".

[Tris]

I just used isset. I prefer it. Its easier to understand when I read over it and it also complies with my coding standards